-
-
Notifications
You must be signed in to change notification settings - Fork 184
Move Surface, draw, transform and image docs to stubs #3389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Surface, draw, transform and image docs to stubs #3389
Conversation
This PR has a few merge conflicts. |
I did a side by side comparison of the old docs and the new docs Surface
Tranform
|
Fixed
Good catch, forgot that private members need to be added to the rst explicitly. Fixed.
Yep, that is intentional. It was a test that was included anyway, I don't think that is a good example. But of course can be added back if others disagree. |
9123aaf
to
3d20ef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR 🎉
I also combed through it, found a few things. Surface.get_locks() return type looks strange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you to resolve those notes as practical, if worth it. But I'm also going to approve, thanks for the PR!
I noticed that too, and assumed it's a fix made in this PR |
19168b3
to
0c10905
Compare
More progress on #2757